test(vmop): add e2e test for VM restore VMOP #1459
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eofff
force-pushed
the
feat/e2e/add-vmop-restore-test
branch
2 times, most recently
from
5a103b6 to
328e7ac
Compare
eofff
force-pushed
the
feat/e2e/add-vmop-restore-test
branch
from
87708f1 to
3ba14c7
Compare
eofff
requested review from
Isteb4k,
yaroslavborbat,
hardcoretime and
danilrwx
as code owners
Isteb4k
requested changes
Sep 22, 2025
tests/e2e/virtual_machine_restore_operation_test/vmop_restore_test_helper.go
Show resolved
Hide resolved
|
|
||
| Context("Removing resources", func() { | ||
| It("Delete resources", func() { | ||
| err := helper.FrameworkEntity.Clients.GenericClient().Delete(context.Background(), helper.VMBDA) |
There was a problem hiding this comment.
Some resources for this test are deleted inside the framework in AfterAll, while some you delete explicitly here. How do you decide which should be deleted where? Maybe delete them all in one place?
There was a problem hiding this comment.
This isn’t a cleanup, it’s to verify that vmop will restore these resources :)
eofff
force-pushed
the
feat/e2e/add-vmop-restore-test
branch
from
2100e0c to
a6925bb
Compare
eofff
force-pushed
the
feat/e2e/add-vmop-restore-test
branch
3 times, most recently
from
d35deba to
94afaca
Compare
Signed-off-by: Valeriy Khorunzhin <[email protected]>
eofff
force-pushed
the
feat/e2e/add-vmop-restore-test
branch
from
94afaca to
8a94e77
Compare
Signed-off-by: Valeriy Khorunzhin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add e2e test for VM restore VMOP.
Why do we need it, and what problem does it solve?
What is the expected result?
Checklist
Changelog entries